net/openvswitch: Use with RCU_INIT_POINTER(x, NULL) in vport-gre.c
authorMonam Agarwal <monamagarwal123@gmail.com>
Sun, 23 Mar 2014 19:22:43 +0000 (00:52 +0530)
committerJesse Gross <jesse@nicira.com>
Fri, 16 May 2014 20:40:29 +0000 (13:40 -0700)
This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL)

The rcu_assign_pointer() ensures that the initialization of a structure
is carried out before storing a pointer to that structure.
And in the case of the NULL pointer, there is no structure to initialize.
So, rcu_assign_pointer(p, NULL) can be safely converted to RCU_INIT_POINTER(p, NULL)

Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Jesse Gross <jesse@nicira.com>
net/openvswitch/vport-gre.c

index 0856f014d7a9d584ef9f13be0bb0accf343722c1..35ec4fed09e228c7e6fe889d2701cb3a3de7748a 100644 (file)
@@ -256,7 +256,7 @@ static void gre_tnl_destroy(struct vport *vport)
 
        ovs_net = net_generic(net, ovs_net_id);
 
-       rcu_assign_pointer(ovs_net->vport_net.gre_vport, NULL);
+       RCU_INIT_POINTER(ovs_net->vport_net.gre_vport, NULL);
        ovs_vport_deferred_free(vport);
        gre_exit();
 }