mmc: dw_mmc: exynos: Warn if HS400 is being used on non-Exynos5420 chipset
authorKrzysztof Kozlowski <k.kozlowski@samsung.com>
Thu, 14 Jul 2016 13:22:27 +0000 (15:22 +0200)
committerUlf Hansson <ulf.hansson@linaro.org>
Mon, 26 Sep 2016 19:31:17 +0000 (21:31 +0200)
Chipsets before Exynos5420 did not support HS400 so if MMC core tries to
configure HS400 timing, this might or might not work.  Warn in such
cases because this is DTB misconfiguration.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/dw_mmc-exynos.c

index da0ef1765735fe48a69a5faf72236598ce1a5cf2..7ab3d749b5aee1728e7aa7a37b530cd42eb741a7 100644 (file)
@@ -225,8 +225,12 @@ static void dw_mci_exynos_config_hs400(struct dw_mci *host, u32 timing)
         * Not supported to configure register
         * related to HS400
         */
-       if (priv->ctrl_type < DW_MCI_TYPE_EXYNOS5420)
+       if (priv->ctrl_type < DW_MCI_TYPE_EXYNOS5420) {
+               if (timing == MMC_TIMING_MMC_HS400)
+                       dev_warn(host->dev,
+                                "cannot configure HS400, unsupported chipset\n");
                return;
+       }
 
        dqs = priv->saved_dqs_en;
        strobe = priv->saved_strobe_ctrl;