altera tse: Fix network-delays and -retransmissions after high throughput.

Fix bug which occurs when more than <limit> packets are available during
napi-poll, leading to "delays" and retransmissions on the network.

Check for (count < limit) before checking the get_rx_status in tse_rx-function.
Function get_rx_status is reading from the response-fifo.
If there is currently a response in the fifo,
reading the last byte of the response pops the value from the fifo.
If the limit is checked as second condition
and the limit is reached the fifo is popped but the packet is not processed.

Signed-off-by: Andreas Oetken <ennoerlangen@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/altera/altera_tse_main.c b/drivers/net/ethernet/altera/altera_tse_main.c
index 79ea35869e1ee31ab7f6cbda2d5b8c676d04bb1c..90a76306ad0fafd441376fb524f1e00e1d202163 100644 (file)
--- a/drivers/net/ethernet/altera/altera_tse_main.c
+++ b/drivers/net/ethernet/altera/altera_tse_main.c
@@ -376,8 +376,13 @@ static int tse_rx(struct altera_tse_private *priv, int limit)
        u16 pktlength;
        u16 pktstatus;
 
-       while (((rxstatus = priv->dmaops->get_rx_status(priv)) != 0) &&
-              (count < limit))  {
+       /* Check for count < limit first as get_rx_status is changing
+       * the response-fifo so we must process the next packet
+       * after calling get_rx_status if a response is pending.
+       * (reading the last byte of the response pops the value from the fifo.)
+       */
+       while ((count < limit) &&
+              ((rxstatus = priv->dmaops->get_rx_status(priv)) != 0)) {
                pktstatus = rxstatus >> 16;
                pktlength = rxstatus & 0xffff;