staging: wilc1000: change handle_get_mac_address's return type to void
authorChaehyun Lim <chaehyun.lim@gmail.com>
Mon, 2 May 2016 10:47:53 +0000 (19:47 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 3 May 2016 21:05:59 +0000 (14:05 -0700)
When handle_get_mac_address is called in hostIFthread that is a kernel
thread, it is not checked return type of this function. This patch
changes return type to void and removes braces if statement due to have
a single statement.

Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/wilc1000/host_interface.c

index 8a269fd19ede5335b5aeed6e2844d223b72823d2..23bbaa8ae933e64a547646f54ede7e647c88788f 100644 (file)
@@ -398,8 +398,8 @@ static void handle_get_ip_address(struct wilc_vif *vif, u8 idx)
                netdev_err(vif->ndev, "Failed to get IP address\n");
 }
 
-static s32 handle_get_mac_address(struct wilc_vif *vif,
-                                 struct get_mac_addr *get_mac_addr)
+static void handle_get_mac_address(struct wilc_vif *vif,
+                                  struct get_mac_addr *get_mac_addr)
 {
        s32 result = 0;
        struct wid wid;
@@ -412,13 +412,9 @@ static s32 handle_get_mac_address(struct wilc_vif *vif,
        result = wilc_send_config_pkt(vif, GET_CFG, &wid, 1,
                                      wilc_get_vif_idx(vif));
 
-       if (result) {
+       if (result)
                netdev_err(vif->ndev, "Failed to get mac address\n");
-               result = -EFAULT;
-       }
        complete(&hif_wait_response);
-
-       return result;
 }
 
 static s32 handle_cfg_param(struct wilc_vif *vif,