[PATCH] aoe: allow multiple aoe devices to have the same mac
authorEd L Cashin <ecashin@coraid.com>
Fri, 29 Apr 2005 14:24:22 +0000 (10:24 -0400)
committerGreg KH <gregkh@suse.de>
Wed, 4 May 2005 06:34:54 +0000 (23:34 -0700)
allow multiple aoe devices to have the same mac

Signed-off-by: Ed L. Cashin <ecashin@coraid.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
diff -u b/drivers/block/aoe/aoedev.c b/drivers/block/aoe/aoedev.c

drivers/block/aoe/aoedev.c

index ec16c64dd114c37b30f2f97bb5e8f895c0a6e9bb..6e231c5a119958dd3549e5d825f4706f9d04f9ec 100644 (file)
@@ -109,25 +109,22 @@ aoedev_set(ulong sysminor, unsigned char *addr, struct net_device *ifp, ulong bu
        spin_lock_irqsave(&devlist_lock, flags);
 
        for (d=devlist; d; d=d->next)
-               if (d->sysminor == sysminor
-               || memcmp(d->addr, addr, sizeof d->addr) == 0)
+               if (d->sysminor == sysminor)
                        break;
 
        if (d == NULL && (d = aoedev_newdev(bufcnt)) == NULL) {
                spin_unlock_irqrestore(&devlist_lock, flags);
                printk(KERN_INFO "aoe: aoedev_set: aoedev_newdev failure.\n");
                return NULL;
-       }
+       } /* if newdev, (d->flags & DEVFL_UP) == 0 for below */
 
        spin_unlock_irqrestore(&devlist_lock, flags);
        spin_lock_irqsave(&d->lock, flags);
 
        d->ifp = ifp;
-
-       if (d->sysminor != sysminor
-       || (d->flags & DEVFL_UP) == 0) {
+       memcpy(d->addr, addr, sizeof d->addr);
+       if ((d->flags & DEVFL_UP) == 0) {
                aoedev_downdev(d); /* flushes outstanding frames */
-               memcpy(d->addr, addr, sizeof d->addr);
                d->sysminor = sysminor;
                d->aoemajor = AOEMAJOR(sysminor);
                d->aoeminor = AOEMINOR(sysminor);