Btrfs: take ordered root lock when removing ordered operations inode
authorJosef Bacik <jbacik@fusionio.com>
Mon, 28 Oct 2013 13:13:25 +0000 (09:13 -0400)
committerChris Mason <chris.mason@fusionio.com>
Tue, 12 Nov 2013 03:08:10 +0000 (22:08 -0500)
A user reported a list corruption warning from btrfs_remove_ordered_extent, it
is because we aren't taking the ordered_root_lock when we remove the inode from
the ordered operations list.  Thanks,

Signed-off-by: Josef Bacik <jbacik@fusionio.com>
Signed-off-by: Chris Mason <chris.mason@fusionio.com>
fs/btrfs/ordered-data.c

index bbb1a38646864d8c55f6880a207ddc37c2f6ce90..8a5eff36659625530153923184cd5bca95005bbd 100644 (file)
@@ -537,7 +537,9 @@ void btrfs_remove_ordered_extent(struct inode *inode,
         */
        if (RB_EMPTY_ROOT(&tree->tree) &&
            !mapping_tagged(inode->i_mapping, PAGECACHE_TAG_DIRTY)) {
+               spin_lock(&root->fs_info->ordered_root_lock);
                list_del_init(&BTRFS_I(inode)->ordered_operations);
+               spin_unlock(&root->fs_info->ordered_root_lock);
        }
 
        if (!root->nr_ordered_extents) {