ACPICA: Remove unnecessary conditional compilation
authorBob Moore <robert.moore@intel.com>
Mon, 19 Oct 2015 02:24:26 +0000 (10:24 +0800)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 22 Oct 2015 00:01:11 +0000 (02:01 +0200)
ACPICA commit eea1f0e561893b6d6417913b2d224082fe3a0a5e

Remove use of ACPI_DEBUGGER and ACPI_DISASSEMBLER where these
defines are used around entire modules.

Note: This type of code also causes problems with IDEs.

Link: https://github.com/acpica/acpica/commit/eea1f0e5
Signed-off-by: Bob Moore <robert.moore@intel.com>
Signed-off-by: Lv Zheng <lv.zheng@intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/acpica/Makefile
drivers/acpi/acpica/acdebug.h
drivers/acpi/acpica/rsdump.c
include/acpi/platform/acenv.h

index fedcc16b56cc5771ce2e6bddadb0705c84122b81..ac78d76572049e9b3381c0cee66b06e502479548 100644 (file)
@@ -123,7 +123,6 @@ acpi-y +=           \
        rsaddr.o        \
        rscalc.o        \
        rscreate.o      \
-       rsdump.o        \
        rsdumpinfo.o    \
        rsinfo.o        \
        rsio.o          \
@@ -179,6 +178,7 @@ acpi-y +=           \
        utxfmutex.o
 
 acpi-$(ACPI_FUTURE_USAGE) +=   \
+       rsdump.o                \
        utcache.o               \
        utfileio.o              \
        utprint.o               \
index eb2e926d8218f04c6bedab32f8dfc5d5febfce90..c928ba494c4000ff71a54bcd4ea022082ee7ccc6 100644 (file)
 #ifndef __ACDEBUG_H__
 #define __ACDEBUG_H__
 
+/* The debugger is used in conjunction with the disassembler most of time */
+
+#ifdef ACPI_DISASSEMBLER
+#include "acdisasm.h"
+#endif
+
 #define ACPI_DEBUG_BUFFER_SIZE  0x4000 /* 16K buffer for return objects */
 
 struct acpi_db_command_info {
index c428bb33204ee89cd01fcb84d0e7e8e8e080a4dc..2a09288e7c57c3d1a6df3a0f93dc9a3b49ed24ac 100644 (file)
@@ -51,7 +51,6 @@ ACPI_MODULE_NAME("rsdump")
 /*
  * All functions in this module are used by the AML Debugger only
  */
-#if defined(ACPI_DEBUGGER)
 /* Local prototypes */
 static void acpi_rs_out_string(char *title, char *value);
 
@@ -565,5 +564,3 @@ static void acpi_rs_dump_word_list(u16 length, u16 *data)
                acpi_os_printf("%25s%2.2X : %4.4X\n", "Word", i, data[i]);
        }
 }
-
-#endif
index ec00e2bb029e6258daa3b0e8db8aa1061fabbc2c..15ef08c048700ff0fc88414f96ca360e6c0bb4d4 100644 (file)
 
 #ifdef ACPI_LIBRARY
 #define ACPI_USE_LOCAL_CACHE
-#define ACPI_FUTURE_USAGE
+#define ACPI_FULL_DEBUG
 #endif
 
 /* Common for all ACPICA applications */