ext4: no need to truncate pagecache twice in collapse range
authorLukas Czerner <lczerner@redhat.com>
Fri, 18 Apr 2014 14:48:25 +0000 (10:48 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Fri, 18 Apr 2014 14:48:25 +0000 (10:48 -0400)
We're already calling truncate_pagecache() before we attempt to do any
actual job so there is not need to truncate pagecache once more using
truncate_setsize() after we're finished.

Remove truncate_setsize() and replace it just with i_size_write() note
that we're holding appropriate locks.

Signed-off-by: Lukas Czerner <lczerner@redhat.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
fs/ext4/extents.c

index c6f624582d37ed1d55fcbd2e8afbf1b04141e1e1..3ee60e2e2ac75334852e7f612f8a2eb1c1dffb2c 100644 (file)
@@ -5474,7 +5474,7 @@ int ext4_collapse_range(struct inode *inode, loff_t offset, loff_t len)
        }
 
        new_size = i_size_read(inode) - len;
-       truncate_setsize(inode, new_size);
+       i_size_write(inode, new_size);
        EXT4_I(inode)->i_disksize = new_size;
 
        ext4_discard_preallocations(inode);