ieee1394: nodemgr: less noise in dmesg
authorStefan Richter <stefanr@s5r6.in-berlin.de>
Fri, 30 Mar 2007 17:19:55 +0000 (19:19 +0200)
committerStefan Richter <stefanr@s5r6.in-berlin.de>
Sun, 29 Apr 2007 22:00:29 +0000 (00:00 +0200)
Everytime when eth1394 or a libraw1394 client updates the configuration
ROM, a certain sysfs attribute cannot be added since it already exists.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
drivers/ieee1394/nodemgr.c

index ddd7aac1e90f42396c1cb041f7e4a33f7d882dcf..9e2404505685c5c683c5882c42faa775a719ca2a 100644 (file)
@@ -1145,13 +1145,14 @@ static void nodemgr_process_root_directory(struct host_info *hi, struct node_ent
                last_key_id = kv->key.id;
        }
 
-       if (ne->vendor_name_kv &&
-           device_create_file(&ne->device, &dev_attr_ne_vendor_name_kv))
-               goto fail;
-       return;
-fail:
-       HPSB_ERR("Failed to add sysfs attribute for node %016Lx",
-                (unsigned long long)ne->guid);
+       if (ne->vendor_name_kv) {
+               int error = device_create_file(&ne->device,
+                                              &dev_attr_ne_vendor_name_kv);
+
+               if (error && error != -EEXIST)
+                       HPSB_ERR("Failed to add sysfs attribute for node "
+                                "%016Lx", (unsigned long long)ne->guid);
+       }
 }
 
 #ifdef CONFIG_HOTPLUG