media: m2m-deinterlace: constify v4l2_m2m_ops structures
authorJulia Lawall <Julia.Lawall@lip6.fr>
Sun, 6 Aug 2017 08:25:17 +0000 (04:25 -0400)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Sun, 20 Aug 2017 12:04:08 +0000 (08:04 -0400)
The v4l2_m2m_ops structures are only passed as the only
argument to v4l2_m2m_init, which is declared as const.
Thus the v4l2_m2m_ops structures themselves can be const.

Done with the help of Coccinelle.

// <smpl>
@r disable optional_qualifier@
identifier i;
position p;
@@
static struct v4l2_m2m_ops i@p = { ... };

@ok1@
identifier r.i;
position p;
@@
v4l2_m2m_init(&i@p)

@bad@
position p != {r.p,ok1.p};
identifier r.i;
struct v4l2_m2m_ops e;
@@
e@i@p

@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
 struct v4l2_m2m_ops i = { ... };
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/platform/m2m-deinterlace.c

index 980066b8d32aeef1a720f52cbad566bb25c64e17..98f6db27b97e525760741ab52100518c44d20763 100644 (file)
@@ -988,7 +988,7 @@ static struct video_device deinterlace_videodev = {
        .vfl_dir        = VFL_DIR_M2M,
 };
 
-static struct v4l2_m2m_ops m2m_ops = {
+static const struct v4l2_m2m_ops m2m_ops = {
        .device_run     = deinterlace_device_run,
        .job_ready      = deinterlace_job_ready,
        .job_abort      = deinterlace_job_abort,