net: phy: dp83867: fix simple_return.cocci warnings
authorWu Fengguang <fengguang.wu@intel.com>
Fri, 24 Jul 2015 06:16:10 +0000 (14:16 +0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 27 Jul 2015 07:59:16 +0000 (00:59 -0700)
drivers/net/phy/dp83867.c:126:1-4: WARNING: end returns can be simpified
drivers/net/phy/dp83867.c:74:5-8: WARNING: end returns can be simpified if tested value is negative or 0

 Simplify a trivial if-return sequence.  Possibly combine with a
 preceding function call.

Generated by: scripts/coccinelle/misc/simple_return.cocci

CC: Dan Murphy <dmurphy@ti.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/dp83867.c

index 8a3bf546989212734aa9a5a5a5b58948ecf264da..32f10662f4ac7c189e3fa666f0891f515d2a4ca1 100644 (file)
@@ -123,12 +123,8 @@ static int dp83867_of_init(struct phy_device *phydev)
        if (ret)
                return ret;
 
-       ret = of_property_read_u32(of_node, "ti,fifo-depth",
+       return of_property_read_u32(of_node, "ti,fifo-depth",
                                   &dp83867->fifo_depth);
-       if (ret)
-               return ret;
-
-       return 0;
 }
 #else
 static int dp83867_of_init(struct phy_device *phydev)