[NETFILTER]: nf_conntrack_h323: turn some printks into DEBUGPs
authorPatrick McHardy <kaber@trash.net>
Sun, 8 Jul 2007 05:38:54 +0000 (22:38 -0700)
committerDavid S. Miller <davem@sunset.davemloft.net>
Wed, 11 Jul 2007 05:18:18 +0000 (22:18 -0700)
Don't spam the ringbuffer with decoding errors. The only printks remaining
are for dropped packets when we're certain they are H.323.

Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/netfilter/nf_conntrack_h323_main.c

index 8c57b8119bfbf8b12d7a74228abafc688da4e475..aa5ba99b7a082f60d69670fd851948d047ce5654 100644 (file)
@@ -163,9 +163,7 @@ static int get_tpkt_data(struct sk_buff **pskb, unsigned int protoff,
                                }
 
                                /* Fragmented TPKT */
-                               if (net_ratelimit())
-                                       printk("nf_ct_h323: "
-                                              "fragmented TPKT\n");
+                               DEBUGP("nf_ct_h323: fragmented TPKT\n");
                                goto clear_out;
                        }
 
@@ -596,10 +594,9 @@ static int h245_help(struct sk_buff **pskb, unsigned int protoff,
                ret = DecodeMultimediaSystemControlMessage(data, datalen,
                                                           &mscm);
                if (ret < 0) {
-                       if (net_ratelimit())
-                               printk("nf_ct_h245: decoding error: %s\n",
-                                      ret == H323_ERROR_BOUND ?
-                                      "out of bound" : "out of range");
+                       DEBUGP("nf_ct_h245: decoding error: %s\n",
+                              ret == H323_ERROR_BOUND ?
+                              "out of bound" : "out of range");
                        /* We don't drop when decoding error */
                        break;
                }
@@ -1137,10 +1134,9 @@ static int q931_help(struct sk_buff **pskb, unsigned int protoff,
                /* Decode Q.931 signal */
                ret = DecodeQ931(data, datalen, &q931);
                if (ret < 0) {
-                       if (net_ratelimit())
-                               printk("nf_ct_q931: decoding error: %s\n",
-                                      ret == H323_ERROR_BOUND ?
-                                      "out of bound" : "out of range");
+                       DEBUGP("nf_ct_q931: decoding error: %s\n",
+                              ret == H323_ERROR_BOUND ?
+                              "out of bound" : "out of range");
                        /* We don't drop when decoding error */
                        break;
                }
@@ -1711,10 +1707,9 @@ static int ras_help(struct sk_buff **pskb, unsigned int protoff,
        /* Decode RAS message */
        ret = DecodeRasMessage(data, datalen, &ras);
        if (ret < 0) {
-               if (net_ratelimit())
-                       printk("nf_ct_ras: decoding error: %s\n",
-                              ret == H323_ERROR_BOUND ?
-                              "out of bound" : "out of range");
+               DEBUGP("nf_ct_ras: decoding error: %s\n",
+                      ret == H323_ERROR_BOUND ?
+                      "out of bound" : "out of range");
                goto accept;
        }