nfsd4: remove redundant stateid initialization
authorJ. Bruce Fields <bfields@redhat.com>
Wed, 7 Sep 2011 16:54:06 +0000 (12:54 -0400)
committerJ. Bruce Fields <bfields@redhat.com>
Tue, 13 Sep 2011 22:29:04 +0000 (18:29 -0400)
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
fs/nfsd/nfs4state.c

index 73b5e1e264fabd84103de046c3917964a1a33909..768382d1de97adf2b17be1b8e8e5115a18f40bc1 100644 (file)
@@ -2318,10 +2318,7 @@ init_open_stateid(struct nfs4_stateid *stp, struct nfs4_file *fp, struct nfsd4_o
        struct nfs4_openowner *oo = open->op_openowner;
        unsigned int hashval = stateid_hashval(oo->oo_owner.so_id, fp->fi_id);
 
-       INIT_LIST_HEAD(&stp->st_hash);
-       INIT_LIST_HEAD(&stp->st_perstateowner);
        INIT_LIST_HEAD(&stp->st_lockowners);
-       INIT_LIST_HEAD(&stp->st_perfile);
        list_add(&stp->st_hash, &stateid_hashtbl[hashval]);
        list_add(&stp->st_perstateowner, &oo->oo_owner.so_stateids);
        list_add(&stp->st_perfile, &fp->fi_stateids);
@@ -3874,10 +3871,6 @@ alloc_init_lock_stateid(struct nfs4_lockowner *lo, struct nfs4_file *fp, struct
        stp = nfs4_alloc_stateid();
        if (stp == NULL)
                goto out;
-       INIT_LIST_HEAD(&stp->st_hash);
-       INIT_LIST_HEAD(&stp->st_perfile);
-       INIT_LIST_HEAD(&stp->st_perstateowner);
-       INIT_LIST_HEAD(&stp->st_lockowners); /* not used */
        list_add(&stp->st_hash, &stateid_hashtbl[hashval]);
        list_add(&stp->st_perfile, &fp->fi_stateids);
        list_add(&stp->st_perstateowner, &lo->lo_owner.so_stateids);