usb: gadget: udc: change comparison to bitshift when dealing with a mask
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Tue, 6 Feb 2018 08:50:40 +0000 (09:50 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 25 May 2018 14:17:41 +0000 (16:17 +0200)
[ Upstream commit ac87e560f7c0f91b62012e9a159c0681a373b922 ]

Due to a typo, the mask was destroyed by a comparison instead of a bit
shift.

Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/gadget/udc/goku_udc.h

index 86d2adafe149a1ccfb811584f1284ce331e34ab5..64eb0f2b5ea00c5b68246f37699cfa41abe3cf06 100644 (file)
@@ -28,7 +28,7 @@ struct goku_udc_regs {
 #      define INT_EP1DATASET           0x00040
 #      define INT_EP2DATASET           0x00080
 #      define INT_EP3DATASET           0x00100
-#define INT_EPnNAK(n)          (0x00100 < (n))         /* 0 < n < 4 */
+#define INT_EPnNAK(n)          (0x00100 << (n))        /* 0 < n < 4 */
 #      define INT_EP1NAK               0x00200
 #      define INT_EP2NAK               0x00400
 #      define INT_EP3NAK               0x00800