[PATCH] x86_64: Remove useless KDB vector
authorAndi Kleen <ak@suse.de>
Wed, 11 Jan 2006 21:45:54 +0000 (22:45 +0100)
committerLinus Torvalds <torvalds@g5.osdl.org>
Thu, 12 Jan 2006 03:05:00 +0000 (19:05 -0800)
It was set as an NMI, but the NMI bit always forces an interrupt
to end up at vector 2. So it was never used. Remove.

Signed-off-by: Andi Kleen <ak@suse.de>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
arch/x86_64/kernel/entry.S
arch/x86_64/kernel/i8259.c
arch/x86_64/kernel/smp.c
arch/x86_64/kernel/traps.c
include/asm-x86_64/hw_irq.h
include/asm-x86_64/ipi.h

index 300555bc56b36e2f3b8ac641df942e4d0787d37d..632fc0f59fccc23a70ff6c8e4b891e4f6ba96b88 100644 (file)
@@ -1040,9 +1040,6 @@ ENTRY(machine_check)
        CFI_ENDPROC
 #endif
 
-ENTRY(call_debug)
-       zeroentry do_call_debug
-
 ENTRY(call_softirq)
        CFI_STARTPROC
        movq %gs:pda_irqstackptr,%rax
index 6e5101ad3d1a075290e3acb298b78e0f5e430c8d..b61965f0fb34e8d3e2796d260bc3d39876d7cb84 100644 (file)
@@ -549,10 +549,9 @@ void __init init_IRQ(void)
                int vector = FIRST_EXTERNAL_VECTOR + i;
                if (i >= NR_IRQS)
                        break;
-               if (vector != IA32_SYSCALL_VECTOR && vector != KDB_VECTOR) { 
+               if (vector != IA32_SYSCALL_VECTOR)
                        set_intr_gate(vector, interrupt[i]);
        }
-       }
 
 #ifdef CONFIG_SMP
        /*
index 6a666d248c1200a3c6caccc1eaeabbc3308fad81..19ef012b1f17a2cda5a539e64ead4e1dd477cde3 100644 (file)
@@ -281,11 +281,6 @@ void flush_tlb_all(void)
        on_each_cpu(do_flush_tlb_all, NULL, 1, 1);
 }
 
-void smp_kdb_stop(void)
-{
-       send_IPI_allbutself(KDB_VECTOR);
-}
-
 /*
  * this function sends a 'reschedule' IPI to another CPU.
  * it goes straight through and wastes no time serializing
index 0827b141c05ea5747aa95c4613441ed190ffecf4..5dee23ba074e73d9df8b2112bb224c2cebc555a1 100644 (file)
@@ -910,11 +910,6 @@ asmlinkage void math_state_restore(void)
        me->thread_info->status |= TS_USEDFPU;
 }
 
-void do_call_debug(struct pt_regs *regs) 
-{ 
-       notify_die(DIE_CALL, "debug call", regs, 0, 255, SIGINT); 
-}
-
 void __init trap_init(void)
 {
        set_intr_gate(0,&divide_error);
@@ -944,8 +939,6 @@ void __init trap_init(void)
        set_system_gate(IA32_SYSCALL_VECTOR, ia32_syscall);
 #endif
        
-       set_intr_gate(KDB_VECTOR, call_debug);
-       
        /*
         * Should be a barrier for any external CPU state.
         */
index b248930767e7d223197c4525ef846bd2b8ebfd9f..0df1715dee7186b1cce490e86c6456d6b7d2466b 100644 (file)
@@ -51,7 +51,8 @@ struct hw_interrupt_type;
 #define ERROR_APIC_VECTOR      0xfe
 #define RESCHEDULE_VECTOR      0xfd
 #define CALL_FUNCTION_VECTOR   0xfc
-#define KDB_VECTOR             0xfb    /* reserved for KDB */
+/* fb free - please don't readd KDB here because it's useless
+   (hint - think what a NMI bit does to a vector) */
 #define THERMAL_APIC_VECTOR    0xfa
 #define THRESHOLD_APIC_VECTOR   0xf9
 /* f8 free */
index 022e9d340ad759cbc763458ed5df2cc186f2eafe..2a5c162b7d925c1fc5ba7b1db1cbf6a8fe2f933a 100644 (file)
@@ -38,10 +38,6 @@ static inline unsigned int __prepare_ICR (unsigned int shortcut, int vector, uns
                icr |= APIC_DM_FIXED | vector;
                break;
        case NMI_VECTOR:
-               /*
-                * Setup KDB IPI to be delivered as an NMI
-                */
-       case KDB_VECTOR:
                icr |= APIC_DM_NMI;
                break;
        }