powerpc/pseries: Fix missing of_node_put() in rng_init()
authorNicholas Mc Guire <hofrat@osadl.org>
Mon, 2 Jul 2018 09:08:16 +0000 (11:08 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 29 Oct 2020 08:07:08 +0000 (09:07 +0100)
[ Upstream commit 67c3e59443f5fc77be39e2ce0db75fbfa78c7965 ]

The call to of_find_compatible_node() returns a node pointer with
refcount incremented thus it must be explicitly decremented here
before returning.

Fixes: a489043f4626 ("powerpc/pseries: Implement arch_get_random_long() based on H_RANDOM")
Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/1530522496-14816-1-git-send-email-hofrat@osadl.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/powerpc/platforms/pseries/rng.c

index 31ca557af60bc82cdc2c089725d0bd382e763d68..262b8c5e1b9d0252c944ce53e636b70177a1a3b0 100644 (file)
@@ -40,6 +40,7 @@ static __init int rng_init(void)
 
        ppc_md.get_random_seed = pseries_get_random_long;
 
+       of_node_put(dn);
        return 0;
 }
 machine_subsys_initcall(pseries, rng_init);