drm/i915: Check the framebuffer offset
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Wed, 31 Oct 2012 15:50:19 +0000 (17:50 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Sun, 11 Nov 2012 22:51:13 +0000 (23:51 +0100)
The current code can't deal with framebuffers with an offset. Return an
error when trying to create such a framebuffer until the rest of the
code is fixed to handle them.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_display.c

index 2b598eb6187208abcfd9136d839b3b562eea22ba..6dae7094f49e35d855742e8ebd6fc10b620e4056 100644 (file)
@@ -8393,6 +8393,10 @@ int intel_framebuffer_init(struct drm_device *dev,
                return -EINVAL;
        }
 
+       /* FIXME need to adjust LINOFF/TILEOFF accordingly. */
+       if (mode_cmd->offsets[0] != 0)
+               return -EINVAL;
+
        ret = drm_framebuffer_init(dev, &intel_fb->base, &intel_fb_funcs);
        if (ret) {
                DRM_ERROR("framebuffer init failed %d\n", ret);