cifs: free nativeFileSystem field before allocating a new one
authorJeff Layton <jlayton@redhat.com>
Mon, 20 Jul 2009 17:40:52 +0000 (13:40 -0400)
committerSteve French <sfrench@us.ibm.com>
Mon, 20 Jul 2009 18:24:37 +0000 (18:24 +0000)
...otherwise, we'll leak this memory if we have to reconnect (e.g. after
network failure).

Signed-off-by: Jeff Layton <jlayton@redhat.com>
CC: Stable <stable@kernel.org>
Signed-off-by: Steve French <sfrench@us.ibm.com>
fs/cifs/connect.c

index e16d7592116ad7dbedd557d8df37497d6370155c..9bb5c8750736e73813ac2f5e50edae28932016e3 100644 (file)
@@ -2726,6 +2726,7 @@ CIFSTCon(unsigned int xid, struct cifsSesInfo *ses,
                strncpy(tcon->treeName, tree, MAX_TREE_SIZE);
 
                /* mostly informational -- no need to fail on error here */
+               kfree(tcon->nativeFileSystem);
                tcon->nativeFileSystem = cifs_strndup_from_ucs(bcc_ptr,
                                                      bytes_left, is_unicode,
                                                      nls_codepage);