drm/edid: Deletion of an unnecessary check before the function call "release_firmware"
authorMarkus Elfring <elfring@users.sourceforge.net>
Wed, 19 Nov 2014 15:33:17 +0000 (16:33 +0100)
committerDave Airlie <airlied@redhat.com>
Fri, 21 Nov 2014 02:16:27 +0000 (12:16 +1000)
The release_firmware() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Reviewed-by: Thierry Reding <thierry.reding@gmail.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
drivers/gpu/drm/drm_edid_load.c

index 0a235fe61c9b9bfd929a1f4a71461bc6ad2bd3d7..732cb6f8e653f58dee7102f0bb11b797cde2f5ad 100644 (file)
@@ -254,8 +254,7 @@ static void *edid_load(struct drm_connector *connector, const char *name,
            name, connector_name);
 
 out:
-       if (fw)
-               release_firmware(fw);
+       release_firmware(fw);
        return edid;
 }