dmaengine: s3c24xx-dma: make phy->irq signed for error handling
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 7 Nov 2013 07:52:00 +0000 (10:52 +0300)
committerVinod Koul <vinod.koul@intel.com>
Tue, 11 Mar 2014 08:53:18 +0000 (14:23 +0530)
There is a bug in s3c24xx_dma_probe() where we do:

phy->irq = platform_get_irq(pdev, i);
if (phy->irq < 0) {

The problem is that "phy->irq" is unsigned so the error handling doesn't
work.  I have changed it to signed.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
drivers/dma/s3c24xx-dma.c

index 4eddedb6eb7dd3deb68550c1b8065e8b9d882278..b209a0f173444f4df6431744b56f7815665e6dff 100644 (file)
@@ -192,7 +192,7 @@ struct s3c24xx_dma_phy {
        unsigned int                    id;
        bool                            valid;
        void __iomem                    *base;
-       unsigned int                    irq;
+       int                             irq;
        struct clk                      *clk;
        spinlock_t                      lock;
        struct s3c24xx_dma_chan         *serving;