nfs: testing the wrong variable
authorDan Carpenter <error27@gmail.com>
Thu, 28 Oct 2010 06:05:57 +0000 (08:05 +0200)
committerTrond Myklebust <Trond.Myklebust@netapp.com>
Thu, 28 Oct 2010 15:18:00 +0000 (11:18 -0400)
The intent was to test "*desc" for allocation failures, but it tests
"desc" which is always a valid pointer here.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
fs/nfs/idmap.c

index dec47ed8b6b9aae84cd9d5071d098870a0267d44..4e2d9b6b1380394cdeca41f0d632eff513b241b8 100644 (file)
@@ -123,7 +123,7 @@ static ssize_t nfs_idmap_get_desc(const char *name, size_t namelen,
        size_t desclen = typelen + namelen + 2;
 
        *desc = kmalloc(desclen, GFP_KERNEL);
-       if (!desc)
+       if (!*desc)
                return -ENOMEM;
 
        cp = *desc;