Staging: mei: fix debug code
authorDan Carpenter <error27@gmail.com>
Thu, 9 Jun 2011 07:18:23 +0000 (10:18 +0300)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 9 Jun 2011 17:07:47 +0000 (10:07 -0700)
! has higher precedence than !=.  H_RDY is 8 and since neither 0 nor
1 are equal to 8 the original condition was always true.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/mei/init.c

index 2818851c07619288821dc6a48e73f7c72c903daa..d1ffa32cd141105b1f9fe4f064ef8b06a53b01e1 100644 (file)
@@ -205,10 +205,10 @@ int mei_hw_init(struct mei_device *dev)
                        "host_hw_state = 0x%08x, me_hw_state = 0x%08x.\n",
                        dev->host_hw_state, dev->me_hw_state);
 
-               if (!(dev->host_hw_state & H_RDY) != H_RDY)
+               if (!(dev->host_hw_state & H_RDY))
                        dev_dbg(&dev->pdev->dev, "host turn off H_RDY.\n");
 
-               if (!(dev->me_hw_state & ME_RDY_HRA) != ME_RDY_HRA)
+               if (!(dev->me_hw_state & ME_RDY_HRA))
                        dev_dbg(&dev->pdev->dev, "ME turn off ME_RDY.\n");
 
                printk(KERN_ERR "mei: link layer initialization failed.\n");