Remove useless reference parameter in PackageUpdateDispatcher::savePackageUpdates()
authorTim Düsterhus <duesterhus@woltlab.com>
Wed, 11 Jan 2023 13:02:18 +0000 (14:02 +0100)
committerTim Düsterhus <duesterhus@woltlab.com>
Wed, 11 Jan 2023 13:02:18 +0000 (14:02 +0100)
This breaks PHP’s CoW and might increase memory usage unnecessarily.

wcfsetup/install/files/lib/system/package/PackageUpdateDispatcher.class.php

index fd7abf59aa217820a1ec539c4f582b28d1dc2625..05d69b1fc802529aaeceacc9f167a0776a18e71f 100644 (file)
@@ -495,7 +495,7 @@ final class PackageUpdateDispatcher extends SingletonFactory
      * @param array $allNewPackages
      * @param int $packageUpdateServerID
      */
-    protected function savePackageUpdates(array &$allNewPackages, $packageUpdateServerID)
+    protected function savePackageUpdates(array $allNewPackages, $packageUpdateServerID)
     {
         $excludedPackagesParameters = $requirementInserts = [];
         $sql = "INSERT INTO wcf1_package_update