drm: qxl: Let DRM core handle connector registering
authorGabriel Krisman Bertazi <krisman@collabora.co.uk>
Thu, 12 Jan 2017 16:16:08 +0000 (14:16 -0200)
committerGustavo Padovan <gustavo.padovan@collabora.com>
Tue, 17 Jan 2017 11:43:50 +0000 (09:43 -0200)
Registering the connector explicitly right after creation is not
necessary for modesetting drivers, because drm_dev_register already takes
care of this on the core side, by calling drm_modeset_register_all.

In addition, performing the initialization too early will get in the way
of the load() hook removal, because the connector interface cannot be
published prior to registering the minors.

Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
CC: Dave Airlie <airlied@redhat.com>
CC: Daniel Vetter <daniel.vetter@ffwll.ch>
CC: dri-devel@lists.freedesktop.org
Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20170112161610.19924-1-krisman@collabora.co.uk
drivers/gpu/drm/qxl/qxl_display.c

index 659c7774264937e28748c5ca5d01c27b01a13210..416ade8566b79be8686a4211b73643b1c0b519b3 100644 (file)
@@ -1077,7 +1077,6 @@ static int qdev_output_init(struct drm_device *dev, int num_output)
                                   dev->mode_config.suggested_x_property, 0);
        drm_object_attach_property(&connector->base,
                                   dev->mode_config.suggested_y_property, 0);
-       drm_connector_register(connector);
        return 0;
 }