projects / GitHub / exynos8895 / android_kernel_samsung_universal8895.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 6ddc9d2)
[ALSA] sound/synth/util_mem.c: remove pointless check
authorAdrian Bunk <bunk@stusta.de>
Mon, 30 Jul 2007 13:40:43 +0000 (15:40 +0200)
committerJaroslav Kysela <perex@perex.cz>
Tue, 16 Oct 2007 13:58:15 +0000 (15:58 +0200)
The Coverity checker spotted that if anyone would call this function
with 'prev == NULL', he would still get an Oops a few lines below.

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz>
sound/synth/util_mem.c patch | blob | blame | history

diff --git a/sound/synth/util_mem.c b/sound/synth/util_mem.c
index 1d9b11f345f891525c00040202fc1adceb534b15..6fc3d2b2519f935c76f1156962d4bae4cd0a6750 100644 (file)
--- a/sound/synth/util_mem.c
+++ b/sound/synth/util_mem.c
@@ -116,7 +116,7 @@ __snd_util_memblk_new(struct snd_util_memhdr *hdr, unsigned int units,
        if (blk == NULL)
                return NULL;
 
-       if (! prev || prev == &hdr->block)
+       if (prev == &hdr->block)
                blk->offset = 0;
        else {
                struct snd_util_memblk *p = get_memblk(prev);