drm/i915: add MISSING_CASE to a few port/aux power domain helpers
authorImre Deak <imre.deak@intel.com>
Fri, 27 Nov 2015 16:55:28 +0000 (18:55 +0200)
committerJani Nikula <jani.nikula@intel.com>
Wed, 2 Dec 2015 14:43:08 +0000 (16:43 +0200)
MISSING_CASE() would have been useful to track down a recent problem in
intel_display_port_aux_power_domain(), so add it there and a few related
helpers. This was also suggested by Ville in his review of the latest
DMC/DC changes, we forgot to address that.

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Patrik Jakobsson <patrik.jakobsson@linux.intel.com>
[Cherry-picked from drm-intel-next-queued b9fec167 (Imre)]
Signed-off-by: Imre Deak <imre.deak@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1448643329-18675-5-git-send-email-imre.deak@intel.com
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/intel_display.c

index ea03006cc08ea6d4572cb2d0c28f02f13644a376..22e86d2e408d9493e6c2ea6a60e689a5c03934a9 100644 (file)
@@ -5194,7 +5194,7 @@ static enum intel_display_power_domain port_to_power_domain(enum port port)
        case PORT_E:
                return POWER_DOMAIN_PORT_DDI_E_2_LANES;
        default:
-               WARN_ON_ONCE(1);
+               MISSING_CASE(port);
                return POWER_DOMAIN_PORT_OTHER;
        }
 }
@@ -5214,7 +5214,7 @@ static enum intel_display_power_domain port_to_aux_power_domain(enum port port)
                /* FIXME: Check VBT for actual wiring of PORT E */
                return POWER_DOMAIN_AUX_D;
        default:
-               WARN_ON_ONCE(1);
+               MISSING_CASE(port);
                return POWER_DOMAIN_AUX_A;
        }
 }
@@ -5275,7 +5275,7 @@ intel_display_port_aux_power_domain(struct intel_encoder *intel_encoder)
                intel_dig_port = enc_to_mst(&intel_encoder->base)->primary;
                return port_to_aux_power_domain(intel_dig_port->port);
        default:
-               WARN_ON_ONCE(1);
+               MISSING_CASE(intel_encoder->type);
                return POWER_DOMAIN_AUX_A;
        }
 }