clk: at91: fix clk-generated parenting
authorAlexandre Belloni <alexandre.belloni@free-electrons.com>
Fri, 12 May 2017 14:25:30 +0000 (16:25 +0200)
committerStephen Boyd <sboyd@codeaurora.org>
Thu, 1 Jun 2017 07:47:50 +0000 (00:47 -0700)
clk_generated_startup is called after clk_hw_register. So the first call to
get_parent will not have the correct value (i.e. 0) and because this is
cached, it may never be updated.

Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Fixes: df70aeef6083 ("clk: at91: add generated clock driver")
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
drivers/clk/at91/clk-generated.c

index 4e1cd5aa69d8aa6c884a5a51198c7ce499b8ee93..70474bd97a10de8887e0b803d6d50d196d899a0b 100644 (file)
@@ -260,13 +260,12 @@ at91_clk_register_generated(struct regmap *regmap, spinlock_t *lock,
        gck->lock = lock;
        gck->range = *range;
 
+       clk_generated_startup(gck);
        hw = &gck->hw;
        ret = clk_hw_register(NULL, &gck->hw);
        if (ret) {
                kfree(gck);
                hw = ERR_PTR(ret);
-       } else
-               clk_generated_startup(gck);
 
        return hw;
 }