projects / GitHub / LineageOS / G12 / android_kernel_amlogic_linux-4.9.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 9405e3c)
V4L/DVB: uvcvideo: Check uvc_ctrl_begin return value in VIDIOC_S_CTRL
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Fri, 5 Feb 2010 00:43:37 +0000 (21:43 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Fri, 26 Feb 2010 18:11:05 +0000 (15:11 -0300)
The function return value wasn't checked due to a missing variable
assignment.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/video/uvc/uvc_v4l2.c patch | blob | blame | history

diff --git a/drivers/media/video/uvc/uvc_v4l2.c b/drivers/media/video/uvc/uvc_v4l2.c
index bf1fc7f29ca78912ebc347fb74762019c1549be4..43152aa522271763ca831edf15671bb6efac3b59 100644 (file)
--- a/drivers/media/video/uvc/uvc_v4l2.c
+++ b/drivers/media/video/uvc/uvc_v4l2.c
@@ -539,7 +539,7 @@ static long uvc_v4l2_do_ioctl(struct file *file, unsigned int cmd, void *arg)
                xctrl.id = ctrl->id;
                xctrl.value = ctrl->value;
 
-               uvc_ctrl_begin(chain);
+               ret = uvc_ctrl_begin(chain);
                if (ret < 0)
                        return ret;