i2c: mux: provide more info on failure in i2c_mux_add_adapter
authorPeter Rosin <peda@axentia.se>
Mon, 3 Apr 2017 07:28:43 +0000 (09:28 +0200)
committerPeter Rosin <peda@axentia.se>
Mon, 3 Apr 2017 12:07:31 +0000 (14:07 +0200)
No callers then need to report any further info, thus reducing both the
amount of code and the log noise.

Reviewed-by: Wolfram Sang <wsa@the-dreams.de>
Signed-off-by: Peter Rosin <peda@axentia.se>
drivers/i2c/i2c-mux.c

index 2178266bca794825e948ce275d48a1b13064056c..26f7237558bad75f8a111037e725a37b519d751e 100644 (file)
@@ -395,13 +395,16 @@ int i2c_mux_add_adapter(struct i2c_mux_core *muxc,
        if (force_nr) {
                priv->adap.nr = force_nr;
                ret = i2c_add_numbered_adapter(&priv->adap);
+               dev_err(&parent->dev,
+                       "failed to add mux-adapter %u as bus %u (error=%d)\n",
+                       chan_id, force_nr, ret);
        } else {
                ret = i2c_add_adapter(&priv->adap);
+               dev_err(&parent->dev,
+                       "failed to add mux-adapter %u (error=%d)\n",
+                       chan_id, ret);
        }
        if (ret < 0) {
-               dev_err(&parent->dev,
-                       "failed to add mux-adapter (error=%d)\n",
-                       ret);
                kfree(priv);
                return ret;
        }