vmbus: replace modulus operation with subtraction
authorStephen Hemminger <stephen@networkplumber.org>
Sun, 12 Feb 2017 06:02:25 +0000 (23:02 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 14 Feb 2017 18:20:35 +0000 (10:20 -0800)
Takes less clock cycles to check for ring wrap and subtract than to
do a modulus instruction.

Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/hv/ring_buffer.c

index 490e9ea098e6bf83781ec88acc443283e379765e..87799e81af97697cb4879acb227a30ea0bf792bd 100644 (file)
@@ -112,7 +112,8 @@ hv_get_next_readlocation_withoffset(const struct hv_ring_buffer_info *ring_info,
        u32 next = ring_info->ring_buffer->read_index;
 
        next += offset;
-       next %= ring_info->ring_datasize;
+       if (next >= ring_info->ring_datasize)
+               next -= ring_info->ring_datasize;
 
        return next;
 }
@@ -156,7 +157,8 @@ static u32 hv_copyfrom_ringbuffer(
        memcpy(dest, ring_buffer + start_read_offset, destlen);
 
        start_read_offset += destlen;
-       start_read_offset %= ring_buffer_size;
+       if (start_read_offset >= ring_buffer_size)
+               start_read_offset -= ring_buffer_size;
 
        return start_read_offset;
 }
@@ -178,7 +180,8 @@ static u32 hv_copyto_ringbuffer(
        memcpy(ring_buffer + start_write_offset, src, srclen);
 
        start_write_offset += srclen;
-       start_write_offset %= ring_buffer_size;
+       if (start_write_offset >= ring_buffer_size)
+               start_write_offset -= ring_buffer_size;
 
        return start_write_offset;
 }