blk-mq-tag: remove redundant check for 'data->hctx' being non-NULL
authorJens Axboe <axboe@fb.com>
Thu, 19 Jan 2017 14:39:17 +0000 (07:39 -0700)
committerJens Axboe <axboe@fb.com>
Thu, 19 Jan 2017 14:43:05 +0000 (07:43 -0700)
We used to pass in NULL for hctx for reserved tags, but we don't
do that anymore. Hence the check for whether hctx is NULL or not
is now redundant, kill it.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: a642a158aec6 ("blk-mq-tag: cleanup the normal/reserved tag allocation")
Signed-off-by: Jens Axboe <axboe@fb.com>
block/blk-mq-tag.c

index 9753747a34a2f411b7bc54bac4e59ac006df3787..5504eb7ed10b287645a7411e6142e6dad2c04fd3 100644 (file)
@@ -136,11 +136,9 @@ unsigned int blk_mq_get_tag(struct blk_mq_alloc_data *data)
                /*
                 * We're out of tags on this hardware queue, kick any
                 * pending IO submits before going to sleep waiting for
-                * some to complete. Note that hctx can be NULL here for
-                * reserved tag allocation.
+                * some to complete.
                 */
-               if (data->hctx)
-                       blk_mq_run_hw_queue(data->hctx, false);
+               blk_mq_run_hw_queue(data->hctx, false);
 
                /*
                 * Retry tag allocation after running the hardware queue,