bnx2x: fill in sane dump flag information

bnx2x did not set dump->version in its .get_dump_flag() method.
Let's set it to BNX2X_DUMP_VERSION. It's not a particularly nice
number (0x50acff01 currently), but at least it's something
deterministic.

dump->flag should report the value previously set using ethtool -W.

Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c
index cf5cebc358b81aa4a93de4af3d1ac9ac20d704fa..c5f225101684f684954bbe9ec0c787cc876ac9b0 100644 (file)
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c
@@ -971,12 +971,12 @@ static int bnx2x_get_dump_flag(struct net_device *dev,
 {
        struct bnx2x *bp = netdev_priv(dev);
 
+       dump->version = BNX2X_DUMP_VERSION;
+       dump->flag = bp->dump_preset_idx;
        /* Calculate the requested preset idx length */
        dump->len = bnx2x_get_preset_regs_len(dev, bp->dump_preset_idx);
        DP(BNX2X_MSG_ETHTOOL, "Get dump preset %d length=%d\n",
           bp->dump_preset_idx, dump->len);
-
-       dump->flag = ETHTOOL_GET_DUMP_DATA;
        return 0;
 }