drm: Fix get_property logic fumble
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Mon, 10 Apr 2017 11:54:45 +0000 (13:54 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 12 Apr 2017 16:11:32 +0000 (18:11 +0200)
Yet again I've proven that I can't negate conditions :(

Testcase: igt/kms_properties/get_property-sanity
Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Reviewed-by: Sean Paul <seanpaul@chromium.org>
Fixes: eb8eb02ed850 ("drm: Drop modeset_lock_all from the getproperty ioctl")
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Sean Paul <seanpaul@chromium.org>
Reported-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20170410115445.13829-1-daniel.vetter@ffwll.ch
drivers/gpu/drm/drm_property.c

index 3feef0659940c97025ce69349bda0c41f807c18f..3e88fa24eab3d382b037a873c6849fe32ead1d46 100644 (file)
@@ -476,7 +476,7 @@ int drm_mode_getproperty_ioctl(struct drm_device *dev,
            drm_property_type_is(property, DRM_MODE_PROP_BITMASK)) {
                list_for_each_entry(prop_enum, &property->enum_list, head) {
                        enum_count++;
-                       if (out_resp->count_enum_blobs <= enum_count)
+                       if (out_resp->count_enum_blobs < enum_count)
                                continue;
 
                        if (copy_to_user(&enum_ptr[copied].value,