pinctrl: pinctrl-st.c: Cleaning up if unsigned is less than zero
authorRickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Thu, 26 Jun 2014 11:32:49 +0000 (13:32 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Fri, 11 Jul 2014 12:08:33 +0000 (14:08 +0200)
Remove checking if a unsigned is less than zero

This was found using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Acked-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Acked-by: Maxime Coquelin <maxime.coquelin@st.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-st.c

index 506561131d7fbea4f8442b2b748cfd9d3c33c56c..1845870413eac07ed2bff42e73d2477896be5d45 100644 (file)
@@ -1250,7 +1250,7 @@ static int st_pctl_parse_functions(struct device_node *np,
        func = &info->functions[index];
        func->name = np->name;
        func->ngroups = of_get_child_count(np);
-       if (func->ngroups <= 0) {
+       if (func->ngroups == 0) {
                dev_err(info->dev, "No groups defined\n");
                return -EINVAL;
        }