[media] rcar-vin: add missing error check to propagate error
authorNiklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Wed, 24 May 2017 00:15:39 +0000 (21:15 -0300)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Tue, 6 Jun 2017 19:44:29 +0000 (16:44 -0300)
The return value of __rvin_try_format_source is not checked, add a check
and propagate the error.

Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/platform/rcar-vin/rcar-v4l2.c

index be6f41bf82ac3bc5499ec4fcbf98bf4c1e01c77f..846bcd87a24ee247559790ed494652d24dd673c0 100644 (file)
@@ -208,6 +208,7 @@ static int __rvin_try_format(struct rvin_dev *vin,
 {
        const struct rvin_video_format *info;
        u32 rwidth, rheight, walign;
+       int ret;
 
        /* Requested */
        rwidth = pix->width;
@@ -235,7 +236,9 @@ static int __rvin_try_format(struct rvin_dev *vin,
        pix->sizeimage = 0;
 
        /* Limit to source capabilities */
-       __rvin_try_format_source(vin, which, pix, source);
+       ret = __rvin_try_format_source(vin, which, pix, source);
+       if (ret)
+               return ret;
 
        switch (pix->field) {
        case V4L2_FIELD_TOP: