projects
/
GitHub
/
exynos8895
/
android_kernel_samsung_universal8895.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
c3f8a50
)
ALSA: rawmidi: Remove kernel WARNING for NULL user-space buffer check
author
Takashi Iwai
<tiwai@suse.de>
Mon, 1 Feb 2016 11:04:55 +0000
(12:04 +0100)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Wed, 17 Feb 2016 20:30:58 +0000
(12:30 -0800)
commit
cc85f7a634cfaf9f0713c6aa06d08817424db37a
upstream.
NULL user-space buffer can be passed even in a normal path, thus it's
not good to spew a kernel warning with stack trace at each time.
Just drop snd_BUG_ON() macro usage there.
BugLink:
http://lkml.kernel.org/r/CACT4Y+YfVJ3L+q0i-4vyQVyyPD7V=OMX0PWPi29x9Bo3QaBLdw@mail.gmail.com
Reported-by: Dmitry Vyukov <dvyukov@google.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/core/rawmidi.c
patch
|
blob
|
blame
|
history
diff --git
a/sound/core/rawmidi.c
b/sound/core/rawmidi.c
index c7dfa571875f7baeabdf1219f3be18197aca7397..26ca02248885708923178c44bfe8b150c9259bf0 100644
(file)
--- a/
sound/core/rawmidi.c
+++ b/
sound/core/rawmidi.c
@@
-1224,7
+1224,7
@@
static long snd_rawmidi_kernel_write1(struct snd_rawmidi_substream *substream,
long count1, result;
struct snd_rawmidi_runtime *runtime = substream->runtime;
- if (
snd_BUG_ON(!kernelbuf && !userbuf)
)
+ if (
!kernelbuf && !userbuf
)
return -EINVAL;
if (snd_BUG_ON(!runtime->buffer))
return -EINVAL;