projects / GitHub / LineageOS / G12 / android_kernel_amlogic_linux-4.9.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: fd5f491)
PowerPC-83xx: Deletion of an unnecessary check before the function call "of_node_put"
authorMarkus Elfring <elfring@users.sourceforge.net>
Sat, 22 Nov 2014 15:18:20 +0000 (16:18 +0100)
committerScott Wood <scottwood@freescale.com>
Fri, 30 Jan 2015 05:16:19 +0000 (23:16 -0600)
The of_node_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Scott Wood <scottwood@freescale.com>
arch/powerpc/platforms/83xx/usb.c patch | blob | blame | history

diff --git a/arch/powerpc/platforms/83xx/usb.c b/arch/powerpc/platforms/83xx/usb.c
index 1ad748bb39b4b506c8596d658d612048946ea46d..5c31d8292d3bb8c0d65d566c57992ca1064af684 100644 (file)
--- a/arch/powerpc/platforms/83xx/usb.c
+++ b/arch/powerpc/platforms/83xx/usb.c
@@ -162,8 +162,7 @@ int mpc831x_usb_cfg(void)
 
        iounmap(immap);
 
-       if (immr_node)
-               of_node_put(immr_node);
+       of_node_put(immr_node);
 
        /* Map USB SOC space */
        ret = of_address_to_resource(np, 0, &res);