ctcm: avoid crash in ctcm_remove_device
authorUrsula Braun <ursula.braun@de.ibm.com>
Tue, 19 May 2009 21:38:38 +0000 (21:38 +0000)
committerDavid S. Miller <davem@davemloft.net>
Thu, 21 May 2009 00:36:49 +0000 (17:36 -0700)
Channels are already removed when setting a ctcm-device offline.
Thus ctcm_remove_device must not refer to channel information.
Solution: delete channel information from the trace call in
ctcm_remove_device.

Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com>
Signed-off-by: Frank Blaschka <frank.blaschka@de.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/s390/net/ctcm_main.c

index 77f4033a0f4fe0b651ed11464241aaab5ce15191..54c4649a493bd27399f107032926662a79370d15 100644 (file)
@@ -1677,10 +1677,8 @@ static void ctcm_remove_device(struct ccwgroup_device *cgdev)
        BUG_ON(priv == NULL);
 
        CTCM_DBF_TEXT_(SETUP, CTC_DBF_INFO,
-                       "removing device %s, r/w = %s/%s, proto : %d",
-                       priv->channel[READ]->netdev->name,
-                       priv->channel[READ]->id, priv->channel[WRITE]->id,
-                       priv->protocol);
+                       "removing device %p, proto : %d",
+                       cgdev, priv->protocol);
 
        if (cgdev->state == CCWGROUP_ONLINE)
                ctcm_shutdown_device(cgdev);