i40evf: free rings in remove function
authorMitch Williams <mitch.a.williams@intel.com>
Mon, 12 Dec 2016 23:44:10 +0000 (15:44 -0800)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Sun, 19 Feb 2017 04:35:35 +0000 (20:35 -0800)
When the i40evf_remove() calls netdev close, the device doesn't actually
close - it schedules the work for the watchdog to perform. Since we're
stopping the watchdog, this work doesn't get done. However, we're
resetting the part, so we can free resources after the reset request has
gone through. This plugs a memory leak.

Change-ID: Id5335dcaf76ce00d2a4c3d26e9faf711d7f051cf
Signed-off-by: Mitch Williams <mitch.a.williams@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/i40evf/i40evf_main.c

index 920c1cb06a92fa8e29696deb863f73e79a82da12..5673dbd2cf7db9a7629e7c95d4a73cba5a0073a7 100644 (file)
@@ -2871,7 +2871,8 @@ static void i40evf_remove(struct pci_dev *pdev)
                i40evf_request_reset(adapter);
                msleep(50);
        }
-
+       i40evf_free_all_tx_resources(adapter);
+       i40evf_free_all_rx_resources(adapter);
        i40evf_misc_irq_disable(adapter);
        i40evf_free_misc_irq(adapter);
        i40evf_reset_interrupt_capability(adapter);