tcp_metrics: Remove the unused return code from tcp_metrics_flush_all
authorEric W. Biederman <ebiederm@xmission.com>
Fri, 13 Mar 2015 05:06:43 +0000 (00:06 -0500)
committerDavid S. Miller <davem@davemloft.net>
Fri, 13 Mar 2015 05:57:07 +0000 (01:57 -0400)
tcp_metrics_flush_all always returns 0.  Remove the unnecessary return code.

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/tcp_metrics.c

index 461c3d2e1ca48329962934dd867e97726670bc51..0d07e14f2ca5c4da1461570e99a26f3a70aaaa76 100644 (file)
@@ -1043,7 +1043,7 @@ out_free:
 
 #define deref_genl(p)  rcu_dereference_protected(p, lockdep_genl_is_held())
 
-static int tcp_metrics_flush_all(struct net *net)
+static void tcp_metrics_flush_all(struct net *net)
 {
        unsigned int max_rows = 1U << net->ipv4.tcp_metrics_hash_log;
        struct tcpm_hash_bucket *hb = net->ipv4.tcp_metrics_hash;
@@ -1064,7 +1064,6 @@ static int tcp_metrics_flush_all(struct net *net)
                        tm = next;
                }
        }
-       return 0;
 }
 
 static int tcp_metrics_nl_cmd_del(struct sk_buff *skb, struct genl_info *info)
@@ -1081,8 +1080,10 @@ static int tcp_metrics_nl_cmd_del(struct sk_buff *skb, struct genl_info *info)
        ret = parse_nl_addr(info, &daddr, &hash, 1);
        if (ret < 0)
                return ret;
-       if (ret > 0)
-               return tcp_metrics_flush_all(net);
+       if (ret > 0) {
+               tcp_metrics_flush_all(net);
+               return 0;
+       }
        ret = parse_nl_saddr(info, &saddr);
        if (ret < 0)
                src = false;