ath9k: downgrade ASSERT() in ath_clone_txbuf()
authorVasanthakumar Thiagarajan <vasanth@atheros.com>
Wed, 10 Jun 2009 12:20:09 +0000 (17:50 +0530)
committerJohn W. Linville <linville@tuxdriver.com>
Fri, 10 Jul 2009 18:57:39 +0000 (14:57 -0400)
We can easily run out of tx buf if there is any stuck in
transmission, so downgrade it to WARN_ON().

Signed-off-by: Vasanthakumar Thiagarajan <vasanth@atheros.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/ath/ath9k/xmit.c

index e08c8174d656e4230178a691b1ba37f262f3f295..5de9878d2c126b0b6d3842681be5207a1b85271e 100644 (file)
@@ -238,6 +238,10 @@ static struct ath_buf* ath_clone_txbuf(struct ath_softc *sc, struct ath_buf *bf)
        struct ath_buf *tbf;
 
        spin_lock_bh(&sc->tx.txbuflock);
+       if (WARN_ON(list_empty(&sc->tx.txbuf))) {
+               spin_unlock_bh(&sc->tx.txbuflock);
+               return NULL;
+       }
        ASSERT(!list_empty((&sc->tx.txbuf)));
        tbf = list_first_entry(&sc->tx.txbuf, struct ath_buf, list);
        list_del(&tbf->list);
@@ -379,6 +383,8 @@ static void ath_tx_complete_aggr(struct ath_softc *sc, struct ath_txq *txq,
                                struct ath_buf *tbf;
 
                                tbf = ath_clone_txbuf(sc, bf_last);
+                               if (!tbf)
+                                       break;
                                ath9k_hw_cleartxdesc(sc->sc_ah, tbf->bf_desc);
                                list_add_tail(&tbf->list, &bf_head);
                        } else {