mtd: rawnand: omap_elm: Fix runtime PM imbalance on error
authorDinghao Liu <dinghao.liu@zju.edu.cn>
Fri, 22 May 2020 10:40:06 +0000 (18:40 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 1 Oct 2020 11:12:46 +0000 (13:12 +0200)
[ Upstream commit 37f7212148cf1d796135cdf8d0c7fee13067674b ]

pm_runtime_get_sync() increments the runtime PM usage counter even
when it returns an error code. Thus a pairing decrement is needed on
the error handling path to keep the counter balanced.

Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20200522104008.28340-1-dinghao.liu@zju.edu.cn
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/mtd/nand/omap_elm.c

index a3f32f939cc1732a1a2938696019dfe9c7bf88a9..6736777a4156794593454fffda69277047ee6bc6 100644 (file)
@@ -421,6 +421,7 @@ static int elm_probe(struct platform_device *pdev)
        pm_runtime_enable(&pdev->dev);
        if (pm_runtime_get_sync(&pdev->dev) < 0) {
                ret = -EINVAL;
+               pm_runtime_put_sync(&pdev->dev);
                pm_runtime_disable(&pdev->dev);
                dev_err(&pdev->dev, "can't enable clock\n");
                return ret;