cxgb4: Fixes static checker warning in mps_tcam_show()
authorHariprasad Shenai <hariprasad@chelsio.com>
Fri, 8 Jan 2016 06:51:25 +0000 (12:21 +0530)
committerDavid S. Miller <davem@davemloft.net>
Mon, 11 Jan 2016 03:42:03 +0000 (22:42 -0500)
The commit 115b56af88b5 ("cxgb4: Update mps_tcam output to include T6
fields") from Dec 23, 2015, leads to the following static checker
warning:

        drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c:1735
mps_tcam_show()
        warn: we tested 'lookup_type' before and it was 'true'

Fixing it.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Hariprasad Shenai <hariprasad@chelsio.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c

index 1bab34f923e726d6b9df2fbec9f00c81d2d18411..e6a4072b494b4322ebb1701fcd2fd7d1c6e6a968 100644 (file)
@@ -1726,13 +1726,13 @@ static int mps_tcam_show(struct seq_file *seq, void *v)
                                seq_printf(seq,
                                           "%3u %02x:%02x:%02x:%02x:%02x:%02x "
                                           "%012llx %06x %06x    -    -   %3c"
-                                          "      %3c  %4x   "
+                                          "      'I'  %4x   "
                                           "%3c   %#x%4u%4d", idx, addr[0],
                                           addr[1], addr[2], addr[3],
                                           addr[4], addr[5],
                                           (unsigned long long)mask,
                                           vniy, vnix, dip_hit ? 'Y' : 'N',
-                                          lookup_type ? 'I' : 'O', port_num,
+                                          port_num,
                                           (cls_lo & T6_SRAM_VLD_F) ? 'Y' : 'N',
                                           PORTMAP_G(cls_hi),
                                           T6_PF_G(cls_lo),