drm/radeon: Limit hdmi deep color bit depth to 12 bpc.
authorMario Kleiner <mario.kleiner.de@gmail.com>
Mon, 5 May 2014 21:03:18 +0000 (23:03 +0200)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 2 Jun 2014 22:37:33 +0000 (18:37 -0400)
DCE-4/5/6 can't support more than 12 bpc deep color over hdmi,
so clamp to 12 bpc when a hdmi deep color capable display is
connected. This even makes sense on DCE-8+, which could do up
to 16 bpc, as driving with more than 12 bpc would only waste
video bandwidth as long as we don't support framebuffers with
more than 12 bpc depth.

On pre-DCE4 we clamp hdmi bit depth to 8 bpc, as those asics
don't support hdmi deep color.

Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/radeon/radeon_connectors.c

index bf73a04791edccd1b5f24bb7dd1c6dec2f297c3a..0dc61dde4c3e196f8860632d0ca3d7f2096f1eff 100644 (file)
@@ -145,6 +145,31 @@ int radeon_get_monitor_bpc(struct drm_connector *connector)
                }
                break;
        }
+
+       if (drm_detect_hdmi_monitor(radeon_connector->edid)) {
+               /* hdmi deep color only implemented on DCE4+ */
+               if ((bpc > 8) && !ASIC_IS_DCE4(rdev)) {
+                       DRM_DEBUG("%s: HDMI deep color %d bpc unsupported. Using 8 bpc.\n",
+                                         drm_get_connector_name(connector), bpc);
+                       bpc = 8;
+               }
+
+               /*
+                * Pre DCE-8 hw can't handle > 12 bpc, and more than 12 bpc doesn't make
+                * much sense without support for > 12 bpc framebuffers. RGB 4:4:4 at
+                * 12 bpc is always supported on hdmi deep color sinks, as this is
+                * required by the HDMI-1.3 spec. Clamp to a safe 12 bpc maximum.
+                */
+               if (bpc > 12) {
+                       DRM_DEBUG("%s: HDMI deep color %d bpc unsupported. Using 12 bpc.\n",
+                                         drm_get_connector_name(connector), bpc);
+                       bpc = 12;
+               }
+       }
+
+       DRM_DEBUG("%s: Display bpc=%d, returned bpc=%d\n",
+                         drm_get_connector_name(connector), connector->display_info.bpc, bpc);
+
        return bpc;
 }