mISDN: grabbing/dropping reference to THIS_MODULE in open/release is racy

... when you have no ->owner set.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

diff --git a/drivers/isdn/mISDN/timerdev.c b/drivers/isdn/mISDN/timerdev.c
index da2aa376a3a398e6b932f28e4f9ea9ca292f2bbd..9438d7ec33080a442f140745e951ac5f01bf3b63 100644 (file)
--- a/drivers/isdn/mISDN/timerdev.c
+++ b/drivers/isdn/mISDN/timerdev.c
@@ -64,7 +64,6 @@ mISDN_open(struct inode *ino, struct file *filep)
        dev->work = 0;
        init_waitqueue_head(&dev->wait);
        filep->private_data = dev;
-       __module_get(THIS_MODULE);
        return nonseekable_open(ino, filep);
 }
 
@@ -94,7 +93,6 @@ mISDN_close(struct inode *ino, struct file *filep)
                kfree(timer);
        }
        kfree(dev);
-       module_put(THIS_MODULE);
        return 0;
 }
 
@@ -269,6 +267,7 @@ mISDN_ioctl(struct file *filep, unsigned int cmd, unsigned long arg)
 }
 
 static const struct file_operations mISDN_fops = {
+       .owner          = THIS_MODULE,
        .read           = mISDN_read,
        .poll           = mISDN_poll,
        .unlocked_ioctl = mISDN_ioctl,