projects / GitHub / moto-9609 / android_kernel_motorola_exynos9610.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 0b824d2)
block2mtd: dubious assignment
authorNicolas Kaiser <nikai@nikai.net>
Fri, 22 Oct 2010 10:47:24 +0000 (12:47 +0200)
committerDavid Woodhouse <David.Woodhouse@intel.com>
Tue, 26 Oct 2010 09:58:00 +0000 (10:58 +0100)
When block2mtd_erase fails, a duplicated assignment instantly
changes instr->state from MTD_ERASE_FAILED to MTD_ERASE_DONE.

It looks to me like this might not be intended, or is it?

Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
Acked-By: Joern Engel <joern@logfs.org>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
drivers/mtd/devices/block2mtd.c patch | blob | blame | history

diff --git a/drivers/mtd/devices/block2mtd.c b/drivers/mtd/devices/block2mtd.c
index 93651865ddbe6892891ce685698fe86153925807..2cf0cc6a418931897d7149978125041172522e9c 100644 (file)
--- a/drivers/mtd/devices/block2mtd.c
+++ b/drivers/mtd/devices/block2mtd.c
@@ -91,7 +91,6 @@ static int block2mtd_erase(struct mtd_info *mtd, struct erase_info *instr)
        } else
                instr->state = MTD_ERASE_DONE;
 
-       instr->state = MTD_ERASE_DONE;
        mtd_erase_callback(instr);
        return err;
 }