watchdog: pretimeout: add pretimeout_available_governors attribute
authorVladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Fri, 7 Oct 2016 12:39:57 +0000 (15:39 +0300)
committerWim Van Sebroeck <wim@iguana.be>
Sat, 8 Oct 2016 08:27:24 +0000 (10:27 +0200)
The change adds an option to a user with CONFIG_WATCHDOG_SYSFS and
CONFIG_WATCHDOG_PRETIMEOUT_GOV enabled to get information about all
registered watchdog pretimeout governors by reading watchdog device
attribute named "pretimeout_available_governors".

Signed-off-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
drivers/watchdog/watchdog_dev.c
drivers/watchdog/watchdog_pretimeout.c
drivers/watchdog/watchdog_pretimeout.h

index 3fdbe0ab136562b8772822415ebdce4ab474861d..32930a073a12744b6d6cf1bcc0b154effea431ab 100644 (file)
@@ -489,6 +489,13 @@ static ssize_t state_show(struct device *dev, struct device_attribute *attr,
 }
 static DEVICE_ATTR_RO(state);
 
+static ssize_t pretimeout_available_governors_show(struct device *dev,
+                                  struct device_attribute *attr, char *buf)
+{
+       return watchdog_pretimeout_available_governors_get(buf);
+}
+static DEVICE_ATTR_RO(pretimeout_available_governors);
+
 static ssize_t pretimeout_governor_show(struct device *dev,
                                        struct device_attribute *attr,
                                        char *buf)
@@ -524,7 +531,8 @@ static umode_t wdt_is_visible(struct kobject *kobj, struct attribute *attr,
        else if (attr == &dev_attr_pretimeout.attr &&
                 !(wdd->info->options & WDIOF_PRETIMEOUT))
                mode = 0;
-       else if (attr == &dev_attr_pretimeout_governor.attr &&
+       else if ((attr == &dev_attr_pretimeout_governor.attr ||
+                 attr == &dev_attr_pretimeout_available_governors.attr) &&
                 (!(wdd->info->options & WDIOF_PRETIMEOUT) ||
                  !IS_ENABLED(CONFIG_WATCHDOG_PRETIMEOUT_GOV)))
                mode = 0;
@@ -541,6 +549,7 @@ static struct attribute *wdt_attrs[] = {
        &dev_attr_status.attr,
        &dev_attr_nowayout.attr,
        &dev_attr_pretimeout_governor.attr,
+       &dev_attr_pretimeout_available_governors.attr,
        NULL,
 };
 
index c9e4a03269382b255384dc9ec52e80182fbd309c..9db07bfb4334fa91428aa0909e9e890a592079ad 100644 (file)
@@ -52,6 +52,21 @@ static struct governor_priv *find_governor_by_name(const char *gov_name)
        return NULL;
 }
 
+int watchdog_pretimeout_available_governors_get(char *buf)
+{
+       struct governor_priv *priv;
+       int count = 0;
+
+       mutex_lock(&governor_lock);
+
+       list_for_each_entry(priv, &governor_list, entry)
+               count += sprintf(buf + count, "%s\n", priv->gov->name);
+
+       mutex_unlock(&governor_lock);
+
+       return count;
+}
+
 int watchdog_pretimeout_governor_get(struct watchdog_device *wdd, char *buf)
 {
        int count = 0;
index 6cd6c89a411c926d30d378c25b9dddf0bd3719a6..a5a32b39c56da3a4ff5b1541be5e3314fb04ee4a 100644 (file)
@@ -18,6 +18,7 @@ void watchdog_unregister_governor(struct watchdog_governor *gov);
 /* Interfaces to watchdog_dev.c */
 int watchdog_register_pretimeout(struct watchdog_device *wdd);
 void watchdog_unregister_pretimeout(struct watchdog_device *wdd);
+int watchdog_pretimeout_available_governors_get(char *buf);
 int watchdog_pretimeout_governor_get(struct watchdog_device *wdd, char *buf);
 int watchdog_pretimeout_governor_set(struct watchdog_device *wdd,
                                     const char *buf);
@@ -38,6 +39,11 @@ static inline void watchdog_unregister_pretimeout(struct watchdog_device *wdd)
 {
 }
 
+static inline int watchdog_pretimeout_available_governors_get(char *buf)
+{
+       return -EINVAL;
+}
+
 static inline int watchdog_pretimeout_governor_get(struct watchdog_device *wdd,
                                                   char *buf)
 {