drm/sti: create fbdev at binding
authorVincent Abriou <vincent.abriou@st.com>
Wed, 4 Jan 2017 12:06:51 +0000 (13:06 +0100)
committerVincent Abriou <vincent.abriou@st.com>
Fri, 6 Jan 2017 14:12:03 +0000 (15:12 +0100)
Do not wait for a hot plug event to create fbdev.

Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Signed-off-by: Vincent Abriou <vincent.abriou@st.com>
drivers/gpu/drm/sti/sti_drv.c

index ff71e25ab5bf30cb288c607fd5e03391172e0d8a..c584d4d03fffbc71d4ad1cce537683091176185b 100644 (file)
@@ -252,19 +252,7 @@ static void sti_output_poll_changed(struct drm_device *ddev)
 {
        struct sti_private *private = ddev->dev_private;
 
-       if (!ddev->mode_config.num_connector)
-               return;
-
-       if (private->fbdev) {
-               drm_fbdev_cma_hotplug_event(private->fbdev);
-               return;
-       }
-
-       private->fbdev = drm_fbdev_cma_init(ddev, 32,
-                                           ddev->mode_config.num_crtc,
-                                           ddev->mode_config.num_connector);
-       if (IS_ERR(private->fbdev))
-               private->fbdev = NULL;
+       drm_fbdev_cma_hotplug_event(private->fbdev);
 }
 
 static const struct drm_mode_config_funcs sti_mode_config_funcs = {
@@ -382,6 +370,8 @@ static void sti_cleanup(struct drm_device *ddev)
 static int sti_bind(struct device *dev)
 {
        struct drm_device *ddev;
+       struct sti_private *private;
+       struct drm_fbdev_cma *fbdev;
        int ret;
 
        ddev = drm_dev_alloc(&sti_driver, dev);
@@ -404,6 +394,17 @@ static int sti_bind(struct device *dev)
 
        drm_mode_config_reset(ddev);
 
+       private = ddev->dev_private;
+       if (ddev->mode_config.num_connector) {
+               fbdev = drm_fbdev_cma_init(ddev, 32, ddev->mode_config.num_crtc,
+                                          ddev->mode_config.num_connector);
+               if (IS_ERR(fbdev)) {
+                       DRM_DEBUG_DRIVER("Warning: fails to create fbdev\n");
+                       fbdev = NULL;
+               }
+               private->fbdev = fbdev;
+       }
+
        return 0;
 
 err_register: