[NET]: Don't exclude broadcast addresses from is_multicast_ether_addr()
authorStephen Hemminger <shemminger@osdl.org>
Tue, 3 Jan 2006 23:25:45 +0000 (15:25 -0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 3 Jan 2006 23:25:45 +0000 (15:25 -0800)
The check for multicast shouldn't exclude broadcast type addresses.
This reverts the incorrect change done in 2.6.13.

The broadcast address is a multicast address and should be excluded
from being a valid_ether_address for use in bridging or device address.

Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/linux/etherdevice.h

index 5f49a30eb6f25d92a5d616e6c0889df7787b0d01..745c988359c0bb29628609062c7d7a59c424ba45 100644 (file)
@@ -63,10 +63,11 @@ static inline int is_zero_ether_addr(const u8 *addr)
  * @addr: Pointer to a six-byte array containing the Ethernet address
  *
  * Return true if the address is a multicast address.
+ * By definition the broadcast address is also a multicast address.
  */
 static inline int is_multicast_ether_addr(const u8 *addr)
 {
-       return ((addr[0] != 0xff) && (0x01 & addr[0]));
+       return (0x01 & addr[0]);
 }
 
 /**