staging: vt6656: Remove all variables ulBulk*
authorMalcolm Priestley <tvboxspy@gmail.com>
Thu, 27 Feb 2014 23:06:09 +0000 (23:06 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 28 Feb 2014 01:09:18 +0000 (17:09 -0800)
None of these variables reach user or in any debug messages.

Remove them all.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vt6656/device.h
drivers/staging/vt6656/usbpipe.c

index ce1587ad55aecececef447d23d7413ac320086ca..50262dc9ef68d6d27d127bc5ec5cb4ade07616a2 100644 (file)
@@ -424,16 +424,6 @@ struct vnt_private {
        DEFAULT_CONFIG config_file;
 
        /* Statistic for USB */
-       unsigned long ulBulkInPosted;
-       unsigned long ulBulkInError;
-       unsigned long ulBulkInContCRCError;
-       unsigned long ulBulkInBytesRead;
-
-       unsigned long ulBulkOutPosted;
-       unsigned long ulBulkOutError;
-       unsigned long ulBulkOutContCRCError;
-       unsigned long ulBulkOutBytesWrite;
-
        unsigned long ulIntInPosted;
        unsigned long ulIntInError;
        unsigned long ulIntInContCRCError;
index 54c68a5119324d1730d038ec3044956223d62cdc..ce396b9c0842c3822ca09411d50ef7186e783c38 100644 (file)
@@ -372,7 +372,6 @@ static void s_nsInterruptUsbIoCompleteRead(struct urb *urb)
                "s_nsInterruptUsbIoCompleteRead Status %d\n", status);
 
        if (status != STATUS_SUCCESS) {
-               priv->ulBulkInError++;
                priv->int_buf.in_use = false;
 
                DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO
@@ -419,8 +418,6 @@ int PIPEnsBulkInUsbRead(struct vnt_private *priv, struct vnt_rcb *rcb)
        if (priv->Flags & fMP_DISCONNECTED)
                return STATUS_FAILURE;
 
-       priv->ulBulkInPosted++;
-
        urb = rcb->pUrb;
        if (rcb->skb == NULL) {
                DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO"rcb->skb is null\n");
@@ -473,8 +470,6 @@ static void s_nsBulkInUsbIoCompleteRead(struct urb *urb)
 
        switch (urb->status) {
        case 0:
-               priv->ulBulkInContCRCError = 0;
-               priv->ulBulkInBytesRead += urb->actual_length;
                break;
        case -ECONNRESET:
        case -ENOENT:
@@ -482,7 +477,6 @@ static void s_nsBulkInUsbIoCompleteRead(struct urb *urb)
                return;
        case -ETIMEDOUT:
        default:
-               priv->ulBulkInError++;
                DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO
                                "BULK In failed %d\n", urb->status);
                break;
@@ -541,7 +535,6 @@ int PIPEnsSendBulkOut(struct vnt_private *priv,
        }
 
        urb = context->pUrb;
-       priv->ulBulkOutPosted++;
 
        usb_fill_bulk_urb(urb,
                        priv->usb,
@@ -622,12 +615,9 @@ static void s_nsBulkOutIoCompleteWrite(struct urb *urb)
        if (status == STATUS_SUCCESS) {
                DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO
                        "Write %d bytes\n", (int)buf_len);
-               priv->ulBulkOutBytesWrite += buf_len;
-               priv->ulBulkOutContCRCError = 0;
        } else {
                DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO
                                "BULK Out failed %d\n", status);
-               priv->ulBulkOutError++;
        }